Mercurial > wow > ouroloot
changeset 126:9232cacc9136 beta-mhg-4
lib-st notes and minor cosmetic cleanup; properly bump version from previous change
| author | Farmbuyer of US-Kilrogg <farmbuyer@gmail.com> |
|---|---|
| date | Sun, 19 Aug 2012 22:00:59 -0400 |
| parents | a9cf9b2fbf9b |
| children | c6d8e096296e |
| files | AceGUIWidget-lib-st.lua gui.lua |
| diffstat | 2 files changed, 8 insertions(+), 11 deletions(-) [+] |
line wrap: on
line diff
--- a/AceGUIWidget-lib-st.lua Sun Aug 19 21:08:59 2012 -0400 +++ b/AceGUIWidget-lib-st.lua Sun Aug 19 22:00:59 2012 -0400 @@ -26,7 +26,7 @@ Version 5 don't bogart the widget object -farmbuyer -------------------------------------------------------------------------------]] -local Type, Version = "lib-st", 4 +local Type, Version = "lib-st", 5 local AceGUI = LibStub and LibStub("AceGUI-3.0", true) if not AceGUI or (AceGUI:GetWidgetVersion(Type) or 0) >= Version then return end @@ -77,9 +77,6 @@ if not st.frame then error"lib-st instance has no '.frame' field... wtf did you pass to this function?" end - --if st.frame.obj and (st.frame.obj ~= self) then - -- error"lib-st instance already has an '.obj' field from a different widget, cannot use with AceGUI!" - --end self.st = st if not st.head then error"lib-st instance has no '.head' field, must use either ScrollingTable:CreateST or this widget's CreateST first" @@ -87,12 +84,10 @@ self.frame = st.frame -- gutsy, but looks doable -- Possibly have already wrapped this ST in a previous widget, careful. - --if st.frame.obj ~= self then - self.frame.customSetPoint = rawget(self.frame,"SetPoint") - self.frame.realSetPoint = self.frame.SetPoint - self.frame.SetPoint = ShiftingSetPoint - self.frame.SetAllPoints = ShiftingSetAllPoints - --end + self.frame.customSetPoint = rawget(self.frame,"SetPoint") + self.frame.realSetPoint = self.frame.SetPoint + self.frame.SetPoint = ShiftingSetPoint + self.frame.SetAllPoints = ShiftingSetAllPoints -- This needs the .frame field. This also unconditionally creates .obj -- inside that field and calls a SetScript on it as well.
--- a/gui.lua Sun Aug 19 21:08:59 2012 -0400 +++ b/gui.lua Sun Aug 19 22:00:59 2012 -0400 @@ -2032,7 +2032,9 @@ Unfortunately, :GetHeight() called on anything useful out of a TabGroup returns the static default size (about 50 pixels) until the refresh cycle *after* all the frames are shown. Trying to fix it up after a - single OnUpdate doesn't work either. So for now it's all hardcoded. + single OnUpdate doesn't work either. So for now it's all hardcoded; + a ScrollingTable requires a row count to determine its height rather + than using SetPoints to constrain a usable area. Using this to determine the actual height of the usable area. (Will error until an ST is shown, which only happens if it's tracking, etc.)