# HG changeset patch # User Nenue # Date 1494821713 14400 # Node ID d594c5c4a4a312ab7fb1d69a1587cad937c10c64 # Parent 5d90d09cb7b7de81008c21d13b7db0604f62665a - Fixed quest markers for other maps becoming visible due to ambiguous interpretations of pin.used. - Removed some redundant filter checking calls on pins obtained through Acquire() - Attempted fix to a source of combat taint. - Attempt to fix quest markers not disappearing immediately after a completion spell is used. diff -r 5d90d09cb7b7 -r d594c5c4a4a3 QuestPOI.lua --- a/QuestPOI.lua Sun May 14 23:54:38 2017 -0400 +++ b/QuestPOI.lua Mon May 15 00:15:13 2017 -0400 @@ -1117,10 +1117,12 @@ self.timeLabel:SetShown(isShown) end -function QuestPOI:Release() +function QuestPOI:Release(msg) print('|cFFFF4400'..self:GetID()..':Release()', self.hideReason) - self.hideReason = 'Released by script.' + self.hideReason = msg or 'Released by script.' + self:SetShown(false) self:HideOrShowFrames(false) + if self.questID then db.QuestsByID[self.questID] = nil for _, map in pairs(db.QuestsByZone) do @@ -1136,7 +1138,6 @@ self.itemTexture = nil self.itemName = nil self.itemNumber = nil - self:SetShown(false) self.animating = nil self.icon:SetAlpha(0) self.RewardBorder:SetAlpha(0) diff -r 5d90d09cb7b7 -r d594c5c4a4a3 WorldQuests.lua --- a/WorldQuests.lua Sun May 14 23:54:38 2017 -0400 +++ b/WorldQuests.lua Mon May 15 00:15:13 2017 -0400 @@ -218,6 +218,7 @@ -- calling this implies that the pin is used in some way if pin then pin:CheckFilterRules() + pin.isStale = true end end @@ -282,7 +283,7 @@ end function Module:OnSecureHook(callbackName, func, ...) - --rprint('|cFFFF4400'..callbackName..'|r', ...) + print('|cFFFF4400'..callbackName..'|r', ...) func(self, ...) end @@ -555,7 +556,7 @@ db.QuestsByZone[mapID][questID] = pin end else - print('|cFFFF4400not using|r', pin.title) + print('|cFFFF4400discarding|r', pin.title) end end end