wow/ouroloot: core.lua comparison

comparison core.lua @ 84:c87bf3e756f3

Properly handle dropdown menus for the History tab now, initially with delete-item and delete-player entries. Some code cleanup and notes for future work.

author	Farmbuyer of US-Kilrogg <farmbuyer@gmail.com>
date	Thu, 21 Jun 2012 02:17:26 +0000
parents	940e53dd18c3
children	4771ee8eaa81

comparison

equal deleted inserted replaced

-:940e53dd18c3
+:c87bf3e756f3
 				if e.kind == 'loot' then
 					if e.history_unique then
 						e.unique, e.history_unique = e.history_unique, nil
 					end
 					if e.unique == nil or #e.unique == 0 then
-						e.unique = e.id .. ' ' .. date("%Y/%m/%d %H:%M",e.stamp)
+						e.unique = e.id .. e.person .. date("%Y/%m/%d %H:%M:%S",e.stamp)
 					end
 				end
 			end
 		end
 	-- DAY is a loot entry with kind=='time', and controls the date printed.
 	-- LOOT may be any kind of entry in the g_loot table.  If present, it
 	--    overrides the hour and minute printed; if absent, those values are
 	--    taken from the DAY entry.
 	-- FORMAT_STRING may contain $x (x in Y/M/D/h/m) tokens.
+	-- FIXME this is horribabble
 	local format_timestamp_values, point2dee = {}, "%.2d"
 	function addon:format_timestamp (fmt_opt, day_entry, time_entry_opt)
 		if not time_entry_opt then
 			if type(fmt_opt) == 'table' then        -- Two entries, default format
 				time_entry_opt, day_entry = day_entry, fmt_opt
 			B:  winner was generated remotely
 			   >need to scan and replace
 			Detecting A is strictly an optimization.  We should be able to do
 			this code safely in all cases.
 			]]
-			if winning_index ~= 1 then
+			if
+--@debug@
+true or
+--@end-debug@
+				winning_index ~= 1 then
 				--XXX this branch still needs to be tested with live data
 				local cache = g_uniques:SEARCH(exist)
 				local looti,hi,ui = cache.loot, cache.history, cache.history_may
 				-- Active loot
 		local i,h = self:get_loot_history(e.person)
 		local when = self:format_timestamp (g_today, e)
 		-- If any of these change, update the end of history_handle_disposition.
 		if (not e.unique) or (#e.unique==0) then
-			e.unique = e.id .. ' ' .. when
+			e.unique = e.id .. e.person .. when
 		end
 		local U = e.unique
 		tinsert (h.unique, 1, U)
 		h.when[U] = when
 		h.id[U] = e.id
 			self:redisplay()
 		end
 		return index
 	end
-	-- Similar to _addHistoryEntry.  The second arg may be a loot entry
+	local function expunge (player, index_or_unique)
-	-- (which used to be at LOOTINDEX), or nil (and the loot entry will
+		local i,u
-	-- be pulled from LOOTINDEX instead).
+		if type(index_or_unique) == 'string' then
-	function addon:_delHistoryEntry (lootindex, opt_e)
+			for u = 1, #player.unique do
-		local e = opt_e or g_loot[lootindex]
+				if player.unique[u] == index_or_unique then
-		if e.kind ~= 'loot' then return end
+					i = u
+					break
-		local from_i, from_h, hist_i = _history_by_loot_id (e, "delete")
+				end
+			end
+		elseif type(index_or_unique) == 'number' then
+			i = index_or_unique
+		end
+		if not i then
+			return -- error here?
+		end
+		u = player.unique[i]
+		assert(#u>0)
+		tremove (player.unique, i)
+		player.when[u], player.id[u], player.count[u] = nil, nil, nil
+		g_uniques[u] = nil
+		addon.hist_clean = nil
+	end
+	-- Mirror of _addHistoryEntry.  Arguments are either:
+	--   E          - loot entry
+	--   U,ITEM     - unique tag, and a name/itemlink for errors
+	-- Returns true on success.
+	function addon:_delHistoryEntry (first, second)
+		if type(first) == 'table' then
+			second = first.itemlink or second
+		--elseif type(first) == 'string' then
+		end
+		local from_i, from_h, hist_i = _history_by_loot_id (first, "delete")
 		if not from_i then
 			-- from_h is the formatted error text
-			self:Print(from_h .. "  Loot will be deleted, but history will NOT be updated.", e.itemlink)
+			return nil, (from_h
-			return
+			        .."  Loot will be deleted, but history will NOT be updated."
-		end
+			       ):format(second)
+		end
-		local hist_u = tremove (from_h.unique, hist_i)
-		from_h.when[hist_u] = nil
+		expunge (from_h, hist_i)
-		from_h.id[hist_u] = nil
+		return true
-		from_h.count[hist_u] = nil
-		g_uniques[hist_u] = nil
-		self.hist_clean = nil
-		self:Print("Removed history entry %d/%s from '%s'.", lootindex, e.itemlink, e.person)
 	end
 	-- Any extra work for the "Mark as <x>" dropdown actions.  The
 	-- corresponding <x> will already have been assigned in the loot entry.
 	local deleted_cache = {}
 		local name = e.person
 		if (newdisp == 'shard' or newdisp == 'gvault') then
 			local name_i, name_h, hist_i = _history_by_loot_id (e, "mark")
 			-- remove history entry if it exists
+			-- FIXME revist this and use expunge
 			if hist_i then
 				local c = flib.new()
 				local hist_u = tremove (name_h.unique, hist_i)
 				c.when = name_h.when[hist_u]
 				c.id = name_h.id[hist_u]
 			-- cache of stuff we've already deleted; if it's not there then just do
 			-- the same steps as _addHistoryEntry.
 			-- FIXME The deleted cache isn't nearly as useful now with the new data structures.
 			local when
 			if (not e.unique) or (#e.unique==0) then
-				when = g_today and self:format_timestamp (g_today, e) or date("%Y/%m/%d %H:%M",e.stamp)
+				when = g_today and self:format_timestamp (g_today, e) or date("%Y/%m/%d %H:%M:%S",e.stamp)
-				e.unique = e.id .. ' ' .. when
+				e.unique = e.id .. name .. when
 			end
 			local U = e.unique
 			local c = deleted_cache[U]
 			deleted_cache[U] = nil
 			name_h.unique[#name_h.unique+1] = U
-			name_h.when[U] = c and c.when or when or date("%Y/%m/%d %H:%M",e.stamp)
+			name_h.when[U] = c and c.when or when or date("%Y/%m/%d %H:%M:%S",e.stamp)
 			name_h.id[U] = e.id -- c.id
 			name_h.count[U] = c and c.count or e.count
 			sort_player(name_h)
 			g_uniques[U] = { loot = index, history = name_i }
 			self.hist_clean = nil

Mercurial > wow > ouroloot

comparison core.lua @ 84:c87bf3e756f3