wow/ouroloot: core.lua comparison

comparison core.lua @ 82:ae17128ef3f2

Cosmetic cleanup. Minor tweaks to fixup_unique_replacements to aid in debugging.

author	Farmbuyer of US-Kilrogg <farmbuyer@gmail.com>
date	Sun, 17 Jun 2012 20:55:11 +0000
parents	0f6355bcfe68
children	940e53dd18c3

comparison

equal deleted inserted replaced

-:0f6355bcfe68
+:ae17128ef3f2
 	-- Recent loot cache
 	local candidates = {}
 	local sigmap = {}
 	local function preempt_older_signature (oldersig, newersig)
---pprint("preempt", oldersig, "::", newersig)
 		local origin = candidates[oldersig] and candidates[oldersig].bcast_from
---pprint("preempt", "candidate", candidates[oldersig], "bcast:", origin)
 		if origin and g_seeing_oldsigs[origin] then
 			-- replace entry from older client with this newer one
 			candidates[oldersig] = nil
 			addon.dprint('loot', "preempting signature <", oldersig, "> from", origin)
 		end
 			local oldersig = recipient .. iname .. (count or "")
 			local signature, seenit
 			if #unique > 0 then
 				-- newer case
 				signature = unique .. oldersig
---pprint("newer", "mapping older <", oldersig, "> to newer <", signature, ">")
 				sigmap[oldersig] = signature
---pprint("newer", "testing recent for", signature, "yields", recent_loot:test(signature))
 				seenit = (from and recent_loot:test(signature))
 					-- The following clause is what handles older 'casts arriving
 					-- earlier.  All this is tested inside-out to maximize short
 					-- circuit evaluation; the preempt function always returns
 					-- false to force seenit off.
 					or (g_seeing_oldsigs and preempt_older_signature(oldersig,signature))
 			else
 				-- older case, only remote
 				assert(from)
 				signature = sigmap[oldersig] or oldersig
---pprint("older", "testing signature will be", signature)
 				seenit = recent_loot:test(signature)
 			end
 			if seenit then
 				self.dprint('loot', "remote", prefix, "<", signature,
 		self.dprint('flow', "restoring", #g_loot, "entries")
 		self:ScheduleTimer("Activate", 12, opts.threshold)
 		-- FIXME printed could be too large if entries were deleted, how much do we care?
 		self.sharder = opts.autoshard
 	else
-		--g_loot = { printed = {}, raiders = {} }
 		g_loot = {}
 	end
 	if type(g_loot.raiders) ~= 'table' then
 		g_loot.raiders = {}
 	end
 	-- Problem:  (1) boss kill happens, (2) fast looting happens, (3) boss
 	-- cache cleanup fires.  Result:  loot shows up before boss kill entry.
 	-- Solution:  We need to shuffle the boss entry above any of the loot
 	-- from that boss.
 	function addon._adjustBossOrder (is, should_be)
-		--pprint('loot', is, should_be)
+		if is == should_be then
-		if is == should_be then --pprint('loot', "equal, yay")
 			return
 		end
 		if (type(is)~='number') or (type(should_be)~='number') or (is < should_be) then
 			pprint('loot', is, should_be, "...the hell? bailing")
 			return
 		end
 		if g_loot[should_be].kind == 'time' then
 			should_be = should_be + 1
 			if is == should_be then
-				--pprint('loot', "needed to mark day entry, otherwise equal, yay")
 				return
 			end
 		end
 		assert(g_loot[is].kind == 'boss')
 		local boss = tremove (g_loot, is)
-		--pprint('loot', "MOVING", boss.bossname)
 		tinsert (g_loot, should_be, boss)
 		return should_be
 	end
 end
 	-- Strictly speaking, we'd want to handle individual 'exist' entries
 	-- as they expire, rather then waiting for all of them to expire and then
 	-- doing them as a group.  But, if there're more than one of these per
 	-- boss, something else is funky anyhow and certainly not a hurry.
 	local function fixup_unique_replacements()
---print("replacements fixup happening!")
---tabledump(g_unique_replace.replacements)
---_G.GRR = g_unique_replace.replacements
 		for exist,info in pairs(gur.replacements) do
 			local winning_index = 1
 			local winner = info[1]
 			info[1] = nil
-			pprint('improv', "fixup for", exist, "starting with", winner[1],
+			pprint('improv', "fixup for", exist, "starting with guid",
-				"with", winner[2], "out of", #info, "total entries")
+				winner[1], "with tag", winner[2], "out of", #info,
+				"total entries")
 			-- Lowest player GUID wins.  Seniority gotta count for something.
 			for i = 2, #info do
 				if winner[1] <= info[i][1] then
 					pprint('improv', "champ wins against", i, info[i][1])
 					flib.del(info[i])
 					winning_index = i
 				end
 				info[i] = nil
 			end
 			pprint('improv', "final:", winner[1], winner[2])
+			--@debug@
+			-- purely a sanity check
+			if winning_index == 1 then
+				if winner[2] ~= info.LOCAL then
+					pprint('improv',
+						"things locally generated are not locally generated?",
+						info.LOCAL, winner[2])
+				end
+			end
+			--@end-debug@
 			--[[
 			A:  winner was generated locally
+			   >winning_index == 1
 			   >g_loot and history already has the replacement value
-			   >winning_index == 1
 			B:  winner was generated remotely
 			   >need to scan and replace
+			Detecting A is strictly an optimization.  We should be able to do
+			this code safely in all cases.
 			]]
 			if winning_index ~= 1 then
---XXX still needs to be debugged:
+				--XXX this branch still needs to be tested with live data
-				local cache = g_uniques[exist]
+				local cache = g_uniques:SEARCH(exist)
-				local looti = assert(cache.loot)  -- can't possibly be missing...
+				local looti,hi,ui = cache.loot, cache.history, cache.history_may
-				if g_loot[looti].unique ~= exist then
-					pprint('improv', "WTF. entry", looti,
+				-- Active loot
-						"does not match original unique tag! instead",
+				if looti and g_loot[looti].unique == exist then
-						g_loot[looti].unique)
-				else
 					pprint('improv', "found and replaced loot entry", looti)
 					g_loot[looti].unique = winner[2]
-				end
+				else
-				local hi,ui = cache.history, cache.history_may
+					-- If winning_index == 1, the "previous" unique would not
+					-- have made it into the tables to begin with.  So don't
+					-- flag an error.  Still should be looked at.
+					pprint('improv', "Um.", looti, g_loot[looti].unique, winning_index)
+				end
+				-- History
 				if hi ~= g_uniques.NOTFOUND then
 					local hist = addon.history[hi]
 					if ui and hist.unique[ui] == exist then
 						-- ui is valid
 					else
 						end
 					end
 					if ui then
 						pprint('improv', "found and replacing history entry", hi,
 							ui, hist.name)
+						assert(exist ~= winner[2])
 						hist.when[winner[2]] = hist.when[exist]
 						hist.id[winner[2]] = hist.id[exist]
 						hist.count[winner[2]] = hist.count[exist]
 						hist.unique[ui] = winner[2]
 						hist.when[exist] = nil
 		addon:horrible_horrible_error (err)
 		-- we don't actually need to kill the GUI in this case
 		addon.NOLOAD = nil
 	end
 end
---function DOTEST()
---	local err = unique_collision:format (
---		"Codpiece of the Grimacing Lunatic",
---		'n3183021', 'Farmbuyer', '14', '78')
---	_unavoidable_collision (err)
---	pprint('ohfuck', "COLLISION", err)
---end
 ------ Saved texts
 function addon:check_saved_table(silent_p)
 	local s = _G.OuroLootSV_saved
 		end
 		for i,e in self:filtered_loot_iter('loot') do
 			if e.unique and e.unique ~= "" then
 				local hmmm = _G.rawget(g_uniques,e.unique)
 				if hmmm then
-					hmmm.loot = i --;print("Active loot", i, "found with tag", e.unique)
+					hmmm.loot = i
 				elseif e.disposition == 'shard' or e.disposition == 'gvault' then
 					g_uniques[e.unique] = { loot = i, history = g_uniques.NOTFOUND }
 					count = count + 1
-					--print("Active loot", i, "INSERTED with tag", e.unique, "as", e.disposition)
 				else
 					hmmm = "active data not found in history ("..i.."/"..tostring(e.unique)
 						..") in precache loop!  trying to fixup for this session"
 					pprint(hmmm)  -- more?
 					-- try to simply fix up errors as we go
 					g_uniques[e.unique] = { loot = i, history = g_uniques.NOTFOUND }
-					--trouble = true
 				end
 			else
 				trouble = true
 				pprint('loot', "ERROR precache loop found bad unique tag!",
 					i, "tag", tostring(e.unique), "from?", tostring(e.bcast_from))
 			or select(2,_G.UnitClass(to_name))
 		self.hist_clean = nil
 		self.loot_clean = nil
 		if how == "local" then
-			--self:Print("Reassigned entry %d/%s from '%s' to '%s'.", index, e.itemlink, from_name, to_name)
 			_notify_about_change (_G.DEFAULT_CHAT_FRAME, _G.UNIT_YOU, index,
 				nil, from_name, from_person_class)
 			self:vbroadcast('reassign', unique, id, from_name, to_name)
 		elseif opts.chatty_on_remote_changes then
 			_notify_about_remote (sender, index, nil, from_name, from_person_class)

Mercurial > wow > ouroloot

comparison core.lua @ 82:ae17128ef3f2