wow/ouroloot: core.lua comparison

comparison core.lua @ 87:9fea75b0927b

If deleting a history entry results in an empty player table, remove that as well. Change g_uniques to store player's name rather than index as the history field, and indirect through the byname table.

author	Farmbuyer of US-Kilrogg <farmbuyer@gmail.com>
date	Fri, 22 Jun 2012 00:58:59 +0000
parents	703bbe61d12d
children	c9f955f9a285

comparison

equal deleted inserted replaced

-:703bbe61d12d
+:9fea75b0927b
 addon.instance_tag = instance_tag   -- grumble
 addon.latest_instance = nil         -- spelling reminder, assigned elsewhere
 -- Memoizing cache of unique IDs as we generate or search for them.  Keys are
 -- the uniques, values are the following:
---   'history'      active index into self.history
+--   'history'      active player name in self.history
 --   'history_may'  index into player's uniques list, CAN QUICKLY BE OUTDATED
 --                  and will instantly be wrong after manual insertion
 --   'loot'         active index into g_loot
 -- with all but the history entry optional.  Values of g_uniqes.NOTFOUND
 -- indicate a known missing status.  Use g_uniques:RESET() to wipe the cache
 		-- If it's active, try looking through that player's history first.
 		if L then
 			local hi,h = addon:get_loot_history (loot.person)
 			for ui,u in ipairs(h.unique) do
 				if k == u then
-					H, HU = hi, ui
+					H, HU = h.name, ui
 					break
 				end
 			end
 		else
 			-- No luck?  Ugh, may have been reassigned and we're probing from
 			-- older data.  Search the rest of current realm's history.
 			for hi,h in ipairs(addon.history) do
 				for ui,u in ipairs(h.unique) do
 					if k == u then
-						H, HU = hi, ui
+						H, HU = h.name, ui
 						break
 					end
 				end
 			end
 		end
 				end
 				return false, u
 			end
 			addon.dprint('loot',"verified unique tag ("..u..")")
 		else
-			-- Need to *find* an unused value.  For now use a range of
+			-- Need to *find* an unused value.  For now use a range of J*10^4
-			-- J*10^4 where J is Jenny's Constant.  Thank you, xkcd.com/1047.
+			-- where J is Jenny's Constant.  Thank you, <xkcd.com/1047>.
 			prefix = prefix or 'n'
 			repeat
 				u = prefix .. random(8675309)
 			until g_uniques:TEST(u).history == g_uniques.NOTFOUND
 			addon.dprint('loot',"created unique tag ("..u..")")
 					pprint('improv', "Um.", looti, g_loot[looti].unique, winning_index)
 				end
 				-- History
 				if hi ~= g_uniques.NOTFOUND then
+					hi = addon.history.byname[hi]
 					local hist = addon.history[hi]
 					if ui and hist.unique[ui] == exist then
 						-- ui is valid
 					else
 						ui = nil
 		local before = GetAddOnMemoryUsage(nametag)
 		local trouble
 		local count = 0
 		for hi,player in ipairs(self.history) do
 			for ui,u in ipairs(player.unique) do
-				g_uniques[u] = { history = hi, history_may = ui }
+				g_uniques[u] = { history = player.name, history_may = ui }
 				count = count + 1
 			end
 		end
 		for i,e in self:filtered_loot_iter('loot') do
 			if e.unique and e.unique ~= "" then
 		local e = g_loot[lootindex]
 		if e.kind ~= 'loot' then return end
 		local i,h = self:get_loot_history(e.person)
 		local when = self:format_timestamp (g_today, e)
+		assert(h.name==e.person)
 		-- If any of these change, update the end of history_handle_disposition.
 		if (not e.unique) or (#e.unique==0) then
 			e.unique = e.id .. e.person .. when
 		end
 		tinsert (h.unique, 1, U)
 		h.when[U] = when
 		h.id[U] = e.id
 		h.count[U] = e.count
-		g_uniques[U] = { loot = lootindex, history = i }
+		g_uniques[U] = { loot = lootindex, history = e.person }
 	end
 	-- Create new history table based on current loot.
 	function addon:rewrite_history (realmname)
 		local r = assert(realmname)
 		if cache.history == g_uniques.NOTFOUND then
 			-- 1) loot an item, 2) clear old history, 3) reassign from current loot
 			-- Bah.  Anybody that tricky is already recoding the tables directly anyhow.
 			errtxt = "There is no record of %s ever having been assigned!"
 		else
-			player_i = cache.history
+			player_i = addon.history.byname[cache.history]
 			player_h = addon.history[player_i]
 			if cache.history_may
 			   and needle == player_h.unique[cache.history_may]
 			then
 				return player_i, player_h, cache.history_may
 				-- from_h here is the formatted error text
 				self:Print(from_h .. "  Loot will be reassigned, but history will NOT be updated.", e.itemlink)
 			end
 		else
 			-- XXX do some sanity checks here?  from_name == from_h.name, etc?
+			-- If something were wrong at this point, what could we do?
 			local U = tremove (from_h.unique, hist_i)
 			-- The loot master giveth...
 			to_h.unique[#to_h.unique+1] = U
 			to_h.when[U] = from_h.when[U]
 			-- ...and the loot master taketh away.
 			from_h.when[U] = nil
 			from_h.id[U] = nil
 			from_h.count[U] = nil
 			-- Blessed be the lookup cache of the loot master.
-			g_uniques[U] = { loot = index, history = to_i }
+			g_uniques[U] = { loot = index, history = to_name }
 		end
 		local from_person_class = e.person_class or from_h.person_class
 			or (g_loot.raiders[from_name] and g_loot.raiders[from_name].class)
 			or select(2,_G.UnitClass(from_name))
 		e.person = to_name
 		assert(#u>0)
 		tremove (player.unique, i)
 		player.when[u], player.id[u], player.count[u] = nil, nil, nil
 		g_uniques[u] = nil
 		addon.hist_clean = nil
+		return #player.unique
 	end
 	-- Mirror of _addHistoryEntry.  Arguments are either:
 	--   E          - loot entry
 	--   U,ITEM     - unique tag, and a name/itemlink for errors
-	-- Returns true on success.
+	-- If this entry was the only one for that player, will also remove that
-	function addon:_delHistoryEntry (first, second)
+	-- player's tables from the history array.
+	--
+	-- On success, returns the number of remaining history entries for that
+	-- player (potentially zero).  On failure, returns nil+error.
+	function addon:_delHistoryEntry (first, item)
 		if type(first) == 'table' then
-			second = first.itemlink or second
+			item = first.itemlink or item
 		--elseif type(first) == 'string' then
 		end
 		local from_i, from_h, hist_i = _history_by_loot_id (first, "delete")
 		if not from_i then
 			-- from_h is the formatted error text
 			return nil, (from_h
 			        .."  Loot will be deleted, but history will NOT be updated."
-			       ):format(second)
+			       ):format(item)
 		end
-		expunge (from_h, hist_i)
+		local remaining = expunge (from_h, hist_i)
-		return true
+		if not remaining then
+			return nil, "Something bizarre happening trying to delete "..item
+		elseif remaining > 0 then
+			return remaining
+		end
+		tremove (self.history, from_i)
+		self:_build_history_names()
+		return 0
 	end
 	-- Any extra work for the "Mark as <x>" dropdown actions.  The
 	-- corresponding <x> will already have been assigned in the loot entry.
 	local deleted_cache = {}
 			name_h.unique[#name_h.unique+1] = U
 			name_h.when[U] = c and c.when or when or date("%Y/%m/%d %H:%M",e.stamp)
 			name_h.id[U] = e.id -- c.id
 			name_h.count[U] = c and c.count or e.count
 			sort_player(name_h)
-			g_uniques[U] = { loot = index, history = name_i }
+			g_uniques[U] = { loot = index, history = name }
 			self.hist_clean = nil
 			if c then flib.del(c) end
 			return

Mercurial > wow > ouroloot

comparison core.lua @ 87:9fea75b0927b