wow/ouroloot: gui.lua comparison

comparison gui.lua @ 114:67bf97136273

- Start paying attention to cross-realm names. New 'fname' and 'realm' keys in snapshot (now indexed by name only), 'person_realm' key in loot entries. Realm data not stored if it's the same as the player's realm. Manual rebroadcasting does not include realm data (do we care?). - New history_suppress_LFR and history_ignore_xrealm options. - This implementation depends on no two cross-realm players sharing the same player name. Is that guaranteed by Blizzard, or merely "unlikely"? - Gather history suppression knobs into a single function. - If restoring loot data, make sure the item cache has their values; fix up any missing data on load. - Memory tweaks for player history sorting. - Handle some long-standing FIXME's: reassigning loot to the same player, using expunge() for history, no partial duplication of effort for addHistoryEntry. - Try to be more graceful when discovering messed up history during column 3 display loops. Don't leave History tab in player-focused mode when all that player's data have been removed elsewhere.

author	Farmbuyer of US-Kilrogg <farmbuyer@gmail.com>
date	Mon, 13 Aug 2012 21:49:08 -0400
parents	cfbaf001fd52
children	fc2ff128835a

comparison

equal deleted inserted replaced

-:d1b914bbed8b
+:67bf97136273
 		for i = (opt_starting_index or self.loot_clean or 1), #g_loot do
 			local e = g_loot[i]
 			if e == nil then
 				self.loot_clean = nil
 				pprint('_f_o_e_d', "index",i,"somehow still in loop past",#g_loot,"bailing")
-				return
+				-- hmm.  used to bail here.  does restarting cause problems?
+				return self:_fill_out_eoi_data(1)
 			end
 			local display_bcast_from = self.db.profile.display_bcast_from
 			-- XXX FIXME a major weakness here is that we're constantly replacing
 			-- what's already been created.  Lots of garbage.  Trying to detect what
 			-- actually needs to be replaced is even worse.  We'll live with
 			-- garbage for now.
 			if e.kind == 'loot' then
 				local textured = eoi_st_textured_item_format:format (e.itexture, ITEM_QUALITY_COLORS[e.quality].hex, e.itemname, e.count or "")
+				local pdisplay = e.person_realm
+					and (e.person .. FOREIGN_SERVER_LABEL) or e.person
 				e.cols = {
 					{value = textured},
-					{value = e.person},
+					{value = pdisplay},
 					{}
 				}
 				-- This is horrible. Must do better.
 				if e.extratext then
 					for disp,text in self:_iter_dispositions('from_notes_text') do
 			for li,unique in ipairs(player.unique) do
 				local col2 = new()
 				col2.OLi   = li
 				col2.OLu   = unique
 				local col3 = new()
-				col3.value = assert(player.when[unique])
+				col3.value = player.when[unique]
+				if not col3.value then
+					col3.hist_miss = true
+					col3.value = '??'
+				end
 				local id = assert(player.id[unique])
 				local itexture = GetItemIcon(id)
 				local iname, ilink, iquality = GetItemInfo(id)
 				local textured
 local function eoi_st_OnEnter (rowFrame, cellFrame, data, cols, row, realrow, column, stable, motion)
 	if (row == nil) or (realrow == nil) then return end  -- mouseover column header
 	local e = data[realrow]
 	if e == nil then return end  -- something horrible has happened
 	local kind = e.kind
+	local cell = e.cols[column]
 	local tt = GameTooltip   -- can this be hoisted? does GT ever get securely replaced?
 	if gui._do_debugging_tooltip and column == 1 and kind ~= 'hist' then
 		_build_debugging_tooltip (cellFrame, realrow)
 	end
 		end
 	elseif kind == 'loot' and column == 2 then
 		tt:SetOwner (cellFrame, "ANCHOR_BOTTOMRIGHT", -50, 5)
 		tt:ClearLines()
-		tt:AddLine(e.person.." Loot:")
+		tt:AddLine(("%s Loot:"):format(e.person_realm
+			and (e.person .. "-" .. e.person_realm) or e.person))
 		local counter = 0
 		for i,e2 in ipairs(data) do
 			if e2.person == e.person then  -- would be awesome to test for alts
 				if counter > 10 then
 					tt:AddLine("...")
 			end
 		end
 		tt:Show()
 	elseif kind == 'loot' and column == 3 then
-		setstatus(e.cols[column].value)
+		setstatus(cell.value)
+	elseif kind == 'hist' and column == 3 and cell.hist_miss then
+		tt:SetOwner (cellFrame, "ANCHOR_RIGHT", -20, 0)
+		tt:ClearLines()
+		tt:AddLine("Corrupted History Data")
+		tt:AddLine([[Close this window, then type]], 0.8, 0.8, 0.8, 1)
+		tt:AddLine([[/ouroloot fix history]], 0, 1, 64/255, nil)
+		tt:AddLine([[and redisplay this window.]], 0.8, 0.8, 0.8, 1)
+		tt:Show()
 	end
 	return false  -- continue with default highlighting behavior
 end
 		gui.dropdown.eoi_loot[1].text = e.itemlink
 		EasyMenu (gui.dropdown.eoi_loot, dropdownmenuframe, cellFrame, 0, 0, "MENU")
 	elseif kind == 'loot' and column == 2 then
 		local ddep = gui.dropdown.eoi_player
-		ddep[1].text = e.person
+		ddep[1].text = e.person -- FIXME realm this too
 		local raiders = {}
 		for i = 1, GetNumRaidMembers() do
 			tinsert (raiders, (GetRaidRosterInfo(i)))
 		end
 		table.sort(raiders)
 		st_widget:WrapST(histST)
 		st_widget.head_offset = 15
 		st_widget.tail_offset = 0
 		container:SetLayout("Fill")
 		container:AddChild(st_widget)
-		setstatus(hist_normal_status)
+		-- If we're focused on one player, but have deleted all entries for
+		-- that player, don't sit there stuck on a blank grid.
+		if history_filter_who and #histST.filtered < 1 then
+			history_filter_who = nil
+			histST:SetFilter(history_filter_by_recent)
+			setstatus(hist_normal_status)
+		else
+			setstatus(hist_name_status)
+		end
 		local b
 		do
 			local realms,current = {},1
 			for realmname,histtable in pairs(addon.history_all) do

Mercurial > wow > ouroloot

comparison gui.lua @ 114:67bf97136273