wow/breuesk: Lists.lua comparison

comparison Lists.lua @ 27:611808dbc0c0

Untested impl for RemovePerson

author	John@Yosemite-PC
date	Sat, 10 Mar 2012 17:21:48 -0500
parents	4c3140c7a1b4
children	eb3a3f69559e

comparison

equal deleted inserted replaced

-:4c3140c7a1b4
+:611808dbc0c0
 -- 3) working state - not saved because it can be so easily calculated
 --
 -- A separate user list is held - lists index into this
--- TODO: list trimming
+-- TODO: switch all action functions to use identifiers rather than names
+-- TODO: collaborative list trimming
 -- TODO: collapse slists into delimited strings for space (premature optimization?)
 -- TODO: organize working state data a little more carefully - hard to keep
 -- track of all the arrays that are floating out there
--- TODO: (meta) remove player from all lists
+-- TODO: (meta) remove/nuke player from all lists
 -- TODO: remove person (trivial unless implementing a history viewer or
 -- something)
 -- holy crap long notes {{{
 -- notes on list storage:
 bsk:DoDeleteList(change)
 elseif change.action == "AddToListEnd" then
 bsk:DoAddPersonToListEnd(change)
 elseif change.action == "AddToListRand" then
 bsk:DoAddPersonToListRandom(change)
+elseif change.action == "RemovePerson" then
+bsk:DoRemovePerson(change)
 elseif change.action == "RemovePersonFromList" then
 bsk:DoRemovePersonFromList(change)
 elseif change.action == "SuicidePerson" then
 bsk:DoSuicidePerson(change)
 else
 assert(false)
 end
 end
 --}}}
+-- holy crap long winded {{{
 -- timestamp logic:
 -- use time() for comparisons - local clients use date() to make it pretty. only
 -- dowisde - we can't have a server timestamp. Which kind of sucks, but it turns
 -- out you can change timezones when you enter an instance server, so you really
 -- never know what time it is.
 --          otherwise ... causality has been violated.
 --  Whenever an admin signon event happens, have the admins each perform a
 --  timestamp check. Issue warnings for anyone with a clock that's more than
 --  X seconds out of sync with the others. Seriously, why isn't NTP a standard
 --  setting on all operating systems ...
+--}}}
 -- Action and DoAction defs {{{
---
+-- Action Discussion {{{
 -- The actual actions for changes start here
 --
 -- Each action occurs as a pair of functions. The bsk:Action() function is from
 -- a list admin's point of view. Each will check for admin status, then create a
 -- change bundle, call the handler for that change (ie the DoAction func), and
 -- change packet. Each Do() function will accept *only* a change packet, and
 -- it's assumed that the change has been vetted elsewhere. These are very blunt
 -- routines.
 --
 -- Note that "undo" has no special voodoo to it. It's basically a change that
--- reverses the prior change on the stack.
+-- reverses the prior change on the stack.--}}}
 function bsk:DoAddPerson(change)--{{{
 assert(change)
 assert(change.arg.id)
 local arg = change.arg
 -- require admin
 if bsk:DoAddPersonToListRandom(change) then
 bsk:CommitChange(change)
 end
 end--}}}
 function bsk:DoRemovePerson(change)--{{{
+local person = bsk.persons[change.arg.id]
--- return true
+personName2id[person.main] = nil
+bsk.persons[change.arg.id] = nil
+bsk.persons.time = change.time
+return true
 end--}}}
 function bsk:RemovePerson(name)--{{{
--- from both persons and lists
+local id = personName2id[name]
+if not id then
+bsk:Print(sformat("%s is not in the persons list, please check your spelling", name))
+return false
+end
+local change = {action="RemovePerson",arg={id=id}}
+bsk:StartChange(change)
+if bsk:DoRemovePerson() then
+bsk:CommitChange(change)
+end
 end--}}}
 function bsk:DoSuicidePerson(change)--{{{
 local list = bsk.lists[change.arg.listIndex]
 local affected = shallowCopy(change.arg.affect)
 -- the goal here is to rotate the suicide list by 1

Mercurial > wow > breuesk

comparison Lists.lua @ 27:611808dbc0c0