wow/askmrrobot: ui/GearComparisonTab.lua comparison

fixed bug with gem changes not appearing sometimes, mainWindow crash on startup, lua error for unknown item tooltips

comparison

equal deleted inserted replaced

-:a401dd0e200e
+:4ba69d2ee252
 current = itemEquipped,
 optimized = itemImported,
 needsUpgrade = needsUpgrade
 }
 elseif itemEquipped then
-if AskMrRobot.ExtraItemData[itemEquipped.id] and AskMrRobot.ExtraItemData[itemEquipped.id].socketColors then
--- items are same, check for gem/enchant differences
+if AskMrRobot.ExtraItemData[itemImported.id] and AskMrRobot.ExtraItemData[itemImported.id].socketColors then
---   NOTE: we used to do a bunch of fancy gem checks, but we can ditch all that logic b/c WoD gems are much simpler (no socket bonuses, gem/socket colors to worry about)
+-- items are same, check for gem/enchant differences
+--   NOTE: we used to do a bunch of fancy gem checks, but we can ditch all that logic b/c WoD gems are much simpler (no socket bonuses, gem/socket colors to worry about)
 local hasBadGems = false
-for g = 1, #AskMrRobot.ExtraItemData[itemEquipped.id].socketColors do
+for g = 1, #AskMrRobot.ExtraItemData[itemImported.id].socketColors do
 if not AskMrRobot.AreGemsCompatible(itemEquipped.gemIds[g], itemImported.gemIds[g]) then
 hasBadGems = true
 break
 end
 end
 result.gems[slotId] = {
 current = {},
 optimized = {}
 }
-for g = 1, #AskMrRobot.ExtraItemData[itemEquipped.id].socketColors do
+for g = 1, #AskMrRobot.ExtraItemData[itemImported.id].socketColors do
 result.gems[slotId].current[g] = itemEquipped.gemIds[g]
 result.gems[slotId].optimized[g] = itemImported.gemIds[g]
 end
 end
 end

Mercurial > wow > askmrrobot